Commit Graph
15 Commits
Author SHA1 Message Date
Andre Hartmann f5ccd9df05 CanFrameModel: Convert switches to enumeration and add documentation
And add or remove default labels to silence Clang compiler warnings.
2017-11-26 18:00:40 +01:00
Andre Hartmann 1b24b1677a CanFrameModel: Remove superflous breaks after return 2017-11-26 18:00:40 +01:00
Andre Hartmann 55273a1b85 CanConnection: Convert switches to enumeration and add documentation
And add or remove default labels to silence Clang compiler warnings.
2017-11-26 18:00:28 +01:00
Andre Hartmann cfc024f98a CanConnectionModel: Remove superflous breaks after return
Clang complained about them.
2017-11-26 16:26:25 +01:00
Andre Hartmann d69947bf2f SerialBusConnection: Use member initialization
And as we have full C++11 support, so its also preferred to use nullptr.
2017-11-25 17:27:47 +01:00
Andre Hartmann 84cb598a0d SerialBusConnection: Improve connect/disconnect handling
* disconnectDevice() already checks mDev_p
* use the error description provided by QCanBus::createDevice()
2017-11-25 17:27:38 +01:00
Andre Hartmann 15aef1afbe SerialBusConnection: Order and condence includes
By practicing the following rules:
(4 and 5 are not needed here)

1. own header
2. project headers
3. Qt headers
4. operating system headers
5. compiler headers
2017-11-25 17:27:28 +01:00
Andre Hartmann 1dd59ed73c SocketCan: Rename to SerialBusConnection
QtCanBus is not limited to SocketCAN, it also supports various
Windows CAN adapters directly.

Also, add the term Connection to describe the inheritance
hierarchy better.
2017-11-25 17:27:19 +01:00
Andre Hartmann 560701e208 Untangle include forrest
Every change in connectionwindow.h led to a heavy project
compile, as the header was included in other headers.

Avoid this by using forward declarations and only include
connectionwindow.h in the C++ files that actually use it.
2017-11-25 17:27:08 +01:00
Andre Hartmann 380e3c9da2 Project: Remove unneeded scope
Qt 4 is not supported at all, as the project requires QtSerialBus.
2017-11-25 17:26:56 +01:00
Andre Hartmann 1f2c5a38a0 Readme: Fix spelling of Qt 2017-11-25 17:26:40 +01:00
Andre Hartmann ee4a218a67 SocketCan: Correctly support CAN frames with extended identifier 2017-09-02 10:09:42 +02:00
Andre Hartmann 3f8e2bb5c3 SocketCan: Allow receiving CAN frames with empty data field
A CAN frame with data size zero is absolutely legal.
2017-09-02 10:09:42 +02:00
Andre Hartmann 74c7b0afc1 SocketCan: Fix compiler warning about missing break 2017-09-02 10:09:35 +02:00
Andre Hartmann c835f36fe9 SocketCan: Fix warnings about old style casts and sign changes 2017-09-02 10:08:01 +02:00