Commit Graph
7 Commits
Author SHA1 Message Date
Andy Huska b9899ee229 Merge branch 'fix_socketcand' 2022-09-17 13:33:00 -05:00
Andy Huska 008ac6b744 Merge branch 'fix_framesenderloadtrailing0x00' 2022-09-17 13:32:47 -05:00
Andy Huska 99640d7239 Fixed data string parsing bug where an empty string created by a trailing space would be interpreted as a 0 and then added as a data byte
This affected editing of the data in the table as well as loading data from a saved file
2022-09-17 13:16:02 -05:00
Andy Huska 6cf404701e Bug was due to treating an empty token as a 0, so fixed the string parsing to ignore empty tokens 2022-09-17 13:04:39 -05:00
Andy Huska 60520b5939 Added handing of ok message from RAW mode switch coming in out of order with other messages...
For now I made it its own else statement so it can be detected
2022-09-17 12:52:03 -05:00
Andy Huska 47d07b8bf2 Fixed bug where switching to RAW mode would fail due to the "ok" response being received in the same message as the first data frame
Sometimes when opening socketcand 1 or more busses won't start right and there's a ton of debug data saying "received datagramm: ...."
It seems to happen because the switch to RAW mode is in progress and we receive the OK with a frame in the same datagramm and we don't parse the OK out of the string
but rather expect the whole string to just be OK.  Offending code is in socketcand.cpp SocketCANd::procRXData line 386

Fixed by looking to see if the < ok > message was at index 0 of the incoming message...could also look for it elsewhere (as in index != -1), but not sure if necessary
2022-09-17 12:48:48 -05:00
Andy Huska 7b966fe4a6 Fixed incorrect handling of partial frame tagged onto the end of a complete frame.
Not sure if my method drops the partial or just sends the buffer back to continue filling.
2022-09-16 15:38:54 -05:00