Commit Graph
25 Commits
Author SHA1 Message Date
Andy Huska d5c0731366 Merge branch 'collin80-master' into add_allowfilterstostayuponclear 2022-09-23 15:40:09 -05:00
Andy Huska 9312cadd88 Merge branch 'master' of https://github.com/collin80/SavvyCAN into collin80-master 2022-09-23 15:39:45 -05:00
Andy Huska 5ffe161210 more clean up 2022-09-23 15:30:58 -05:00
Andy Huska f38e0b0bfa Took out unnecessary exception recover code
Cuz app is going to crash anyway, no need to make a mess
2022-09-23 15:28:41 -05:00
Andy Huska aea5e9f9c8 Merge branch 'fix_dbc_delete' of github.com:qurrent-llc/SavvyCAN into fix_dbc_delete 2022-09-20 07:51:45 -05:00
Andy Huska 13c920f971 Fixed regression where non-commented node would not delete
Fixed odd crash due to dbcNode being null on refresh
2022-09-20 07:46:30 -05:00
Andy Huska cb94cac205 Fixed issue where filteredFrames was having its capacity changed
when adjusting filters due to appending a QVector of frames which
appears to change the capacity to the number of items appended.
Also fixed bug where preallocsize was being locally defined and
therefore the global version wasn't being updated with unknown
effets.
2022-09-19 13:47:57 -05:00
Andy Huska 6fa84df7e0 Added ability to maintain bus and msg filters when clearing frames 2022-09-19 13:31:00 -05:00
Andy Huska 07d1610a63 Merge branch 'fix_addframebadalloc' 2022-09-19 13:11:22 -05:00
Andy Huska d56b35ea91 Made max # of frames an option in preferences, restart to take effect 2022-09-19 13:10:33 -05:00
Andy Huska fd657b9b9b Merge branch 'fix_addframebadalloc' 2022-09-19 12:48:43 -05:00
Andy Huska 195c90c415 change the max amount of the reserved space for the frames and filteredFrames vectors
to be 99% of the capacity instead of 95%.
Reset initial capacity to be 10M frames for 64-bit machines now that testing is done.
Want to make the capacity adjustable by user, too.
2022-09-18 13:01:34 -05:00
Andy Huska dfc7b095c8 Added node name as part of the signal name that gets copied into the data table 2022-09-17 13:54:59 -05:00
Andy Huska e06112b14c Merge branch 'fix_dbc_delete' 2022-09-17 13:33:13 -05:00
Andy Huska b9899ee229 Merge branch 'fix_socketcand' 2022-09-17 13:33:00 -05:00
Andy Huska 008ac6b744 Merge branch 'fix_framesenderloadtrailing0x00' 2022-09-17 13:32:47 -05:00
Andy Huska 99640d7239 Fixed data string parsing bug where an empty string created by a trailing space would be interpreted as a 0 and then added as a data byte
This affected editing of the data in the table as well as loading data from a saved file
2022-09-17 13:16:02 -05:00
Andy Huska 6cf404701e Bug was due to treating an empty token as a 0, so fixed the string parsing to ignore empty tokens 2022-09-17 13:04:39 -05:00
Andy Huska 57f506b4dd Merge branch 'fix_socketcand' into fix_addframebadalloc 2022-09-17 12:53:57 -05:00
Andy Huska 60520b5939 Added handing of ok message from RAW mode switch coming in out of order with other messages...
For now I made it its own else statement so it can be detected
2022-09-17 12:52:03 -05:00
Andy Huska 47d07b8bf2 Fixed bug where switching to RAW mode would fail due to the "ok" response being received in the same message as the first data frame
Sometimes when opening socketcand 1 or more busses won't start right and there's a ton of debug data saying "received datagramm: ...."
It seems to happen because the switch to RAW mode is in progress and we receive the OK with a frame in the same datagramm and we don't parse the OK out of the string
but rather expect the whole string to just be OK.  Offending code is in socketcand.cpp SocketCANd::procRXData line 386

Fixed by looking to see if the < ok > message was at index 0 of the incoming message...could also look for it elsewhere (as in index != -1), but not sure if necessary
2022-09-17 12:48:48 -05:00
Andy Huska 742956d46c Working on finding a way to prevent bad_alloc crash, temp stuff in place like prealloc size, and frames list resize (prob need to keep list below size limit to prevent chaos...10M msgs or so mabe) 2022-09-17 12:33:15 -05:00
Andy Huska 7b966fe4a6 Fixed incorrect handling of partial frame tagged onto the end of a complete frame.
Not sure if my method drops the partial or just sends the buffer back to continue filling.
2022-09-16 15:38:54 -05:00
Andy Huska 7e4ebf2c74 Fixed nonfunctional node delete. Was due to trying to find node by name but
passing in the name and comment concatenated together.  Made a new function to
find by name+comment since extracting only name from the text in the column would
require too much guessing.
2022-09-15 18:59:24 -05:00
Andy Huska b6b73d0e11 Fixed crash when deleting a message that isn't at the bottom of the node 2022-09-15 18:39:56 -05:00