Commit Graph
34 Commits
Author SHA1 Message Date
Andy Huska 42fe841f0a Clean up last bits of debugging 2022-11-02 16:40:25 -05:00
Andy Huska a7acaac2fb Cleaned out comment blocks from debug and fixed framesender not showing
count until a number is manually entered (it was seeing the null item,
creating the item, but not putting it in the table).
2022-11-02 15:32:39 -05:00
Andy Huska 1b41decd20 Custom sender is no longer crashing
There are a TON of explorations I did here, many may be unnecessary, but this is a stake in the ground.

The main issue was the strange queue logic in canconmanager::sendFrame which puts the tx data in the rx
queue so it will show up in the displayed data.  It caused SIGABRT and SIGSEG to show up everywhere.
It is NOT fixed yet, but TX works over the wire you just can't see it in the tableview.

I thought at first it was only when overwrite data was active, so I put in a a pile of changes to keep
frames and filtered frames as two seperate copies of data where frames was always complete and filtered
was only what was seen in the mainwindow.  It made it so the graphing window would work with overwrite
data active which is an improvement.  I wouldn't roll these changes back.  Because of these changes I
had to update the frame sorting code adjust the refresh function in canframemode.cpp

I also thought it was related to UI updates, but its not, that's been confirmed.

I put a mutex around the custom sender tick timer so that the 1ms timer wouldn't re-enter its callback.
This didn't fix the crash, but it sure seems to make a lot of sense, and the way I did it no elasped
time is lost for tracking purposes, and in reality theres no way 1ms was consistent anyway.

I put a mutex around the shrinking of frames and filteredframes to make sure we weren't deleting at
the same time as accessing, but honestly we acccess those lists in many places without semaphores so
that probably did nothing.

Fixed a bug in FrameSenderWindow:DoModifiers that was improperly parsing and sometimes crashing when
looking for the ~ operator before a symbol.

Also added some minor work to keep row expansion functioning when changing filters or sorting.  Need
to make some tweaks so it stops trying so hard when overwrite is not active

Theres also code in main.c taht makes debugging output super verbose.

Committing now to start cleanup
2022-11-01 15:01:07 -05:00
Ludovic LANGE 768ebf9966 replace QString::SkipEmptyParts with Qt::SkipEmptyParts (qt6)
`QString::SkipEmptyParts` is [deprecated since around Qt5.14](https://doc.qt.io/qt-5/qstring-obsolete.html),
and has been removed in Qt6.

We replace it with `Qt::SkipEmptyParts` for Qt >= 5.14
2022-09-27 21:04:19 +02:00
Andy Huska 99640d7239 Fixed data string parsing bug where an empty string created by a trailing space would be interpreted as a 0 and then added as a data byte
This affected editing of the data in the table as well as loading data from a saved file
2022-09-17 13:16:02 -05:00
Collin Kidder f53ad8a65a Fixed help system.
Also switched from Sphinx generated HTML to GitHub markup help files.

This improves compatibility and will allow the help files to more easily be viewed on github as well.
2021-05-30 23:40:47 -04:00
Bertrand 39a1d2e17d resetting counter when line disabled
you can now send a message 3 times, deactivate and activate to send a message 3 times again.
2021-02-26 07:45:53 +01:00
Cyber MacGeddon ca83d77d2f Modify the parsing of the 'id' trigger. Documentation says that trigger
should be 'id' followed by the ID and gives the example 'id0x200'.
This commit changes parsing to match the docs, previously the character
between prefix and number was ignored, so that 'id:0x200' would work,
but 'id0x200' would not.
2020-11-04 16:19:38 +00:00
Collin Kidder 367c072b45 Various fixes to issues caused by recent transition to QCanBusFrame 2020-02-18 21:31:18 -05:00
Collin Kidder d550fa79a0 Changed a lot of pointer references to const (it's more correct and
fixes a weird problem), fixed a problem with JSON to DBC, a few other
fixes
2020-02-13 22:01:06 -05:00
Collin Kidder 8beb0e31a0 Converted more code to be easier to generalize to larger CAN payloads
for CAN-FD. Improved some code to be faster. Fixed up some compile
time warnings.
2019-12-15 15:02:06 -05:00
Collin Kidder ef24036d1c Finished switching over everything to the new can format (I hope). It
seems to function now but much more testing is needed.
2019-12-13 21:06:48 -05:00
Collin Kidder e7e65b7216 Fixed up a bunch of compiler warnings.
There should be no functional difference, just less noise when compiling
2019-08-08 21:15:51 -04:00
Collin Kidder d4a735a710 Allow many places to load and save the last directory used for that functionality so it can easily be used again.
All frame file I/O uses the same directory load/save location but DBC files store separately as do filter files, graphing definitions, and stored text files from the various reverse engineering windows.
2019-06-17 20:58:56 -04:00
Collin Kidder d4f52311f7 Fix to correct a few places where 2 buses were hard coded as the
limit. There is no hard and fast limit to the number of buses you can
have now.
2019-02-19 21:19:51 -05:00
MartinX 52f04791dd add setWindowFlags(Qt::Window) to improve window management
* improves window handling a lot
	(on Linux GNOME 3 at least: quickly resizing windows left/right, not forced in foreground anymore etc.)
	setWindowFlags() inserted in all *window.cpp files except mainwindow
    * some whitespace at EOL trimmed
2019-02-13 20:08:41 +01:00
Collin Kidder 025b8ef6da Fix to allow custom frame sender window to send frames with ID = 0 2018-06-04 19:34:47 -04:00
Fabián Inostroza b8896d76b6 Make SavvyCAN aware of remote frames. 2018-04-29 18:52:31 -03:00
Collin Kidder a3a2186357 Fix crash when loading grid in custom sender. Fix a few other issues while working on that form. 2017-12-14 19:43:38 -05:00
Collin Kidder 9302c18c33 Integrated help into the system. Most all the sub-screens that are actually complete
and working have integrated help now. Press F1 to bring up help for a given window.
2017-11-30 21:02:16 -05:00
Collin Kidder c05bd2c043 Added flow control and other functionality to UDS / ISO_TP code. 2017-08-13 17:03:11 -04:00
Collin Kidder 7222870b1e Many little fixes to clean up warnings and bugs. 2016-12-29 20:50:02 -05:00
Collin Kidder ddfac100d2 Changed sending windows to use new system where there are arbitrary number of buses 2016-12-08 20:21:42 -05:00
Collin Kidder a3cd14e495 Additional implementation of the new connection scheme. It is now possible to send frames to CANConnection objects indirectly based on registered bus number.
This further abstracts the interface. Things are reasonably stable now for frame reception. Initial work has been done to support frame transmission as well. This is currently less stable but mostly working.
2016-03-27 22:37:02 -04:00
Collin Kidder f8e72986f0 Fixed parsing and processing of modifiers in custom frame sender
window. Added serialbus to project (Qt5.6 dependency)
2016-02-25 21:09:48 -05:00
Collin Kidder 48fb208f8b Fixed crash bug found in many sub screens, made UDS scanner work better. 2016-01-29 15:03:29 -05:00
Collin Kidder 3ed0ac4880 Added bitwise not and modulus division to the list of operations you
can do with modifiers in the custom frame window
2015-11-23 09:19:47 -05:00
Collin Kidder 629ad5ec6c Additional work to clean up warnings and make the code more robust. 2015-08-26 22:22:24 -04:00
Collin Kidder 248538e943 Modification of the modifier parsing strategy to allow for a lot more leeway in how you enter the values in. Previously the syntax was *VERY* strict. Now it's easier to get it to accept your modifier strings. 2015-08-17 21:19:12 -04:00
Collin Kidder 7f0c077891 Fixed it up so triggering on frames works too. 2015-08-16 20:15:18 -04:00
Collin Kidder 3f5d8b6159 Much work on custom frame sender window. It is reasonably functional now and tested for timed sending 2015-08-16 20:00:35 -04:00
Collin Kidder 1af5c10506 Fix to make access of canbus frames const correct. It's now not really possible to modify the captured canbus frames from outside the model class that holds them. This is safer and more future proof.
Boring update but it might save head scratching in the future.
2015-06-24 20:44:38 -04:00
Collin Kidder ae7a301cfb Update the entire program to use QVector. This should make the performance better. Still trying to preallocate enough space for 10,000,000 frames which should be more than plenty. 2015-05-22 23:33:08 -04:00
Collin Kidder 176680672a Some implementation of the custom frame sender interface and the DBC loading functionality. Both compile as-is but are not functional yet. This is an in-process update. 2015-05-17 22:16:19 -04:00