Minor: DBCComparatorWindow: sanity checks to fix gcc warnings

This commit is contained in:
Alexey Esaulenko
2024-01-19 15:01:14 +04:00
parent 2082845d03
commit a86a78e19a
+6 -4
View File
@@ -222,8 +222,8 @@ void DBCComparatorWindow::calculateDetails()
ui->treeDetails->addTopLevelItem(msgDiffRoot);
QTreeWidgetItem *msgItem;
QTreeWidgetItem *sigTemp;
QTreeWidgetItem *msgItem {};
QTreeWidgetItem *sigTemp {};
for (int i = 0; i < firstDBC->messageHandler->getCount(); i++)
{
@@ -257,7 +257,8 @@ void DBCComparatorWindow::calculateDetails()
msgItem->setText(0, msgName + " (" + Utility::formatCANID(thisMsg->ID) + ")");
sigDiffTwo->addChild(msgItem);
}
msgItem->addChild(missingSigItem);
if (msgItem)
msgItem->addChild(missingSigItem);
}
else //signal exists on both sides. See if it as changed position or length
{
@@ -301,7 +302,8 @@ void DBCComparatorWindow::calculateDetails()
sigTemp->setText(0, msgName + " (" + Utility::formatCANID(thisMsg->ID) + ")");
sigModifiedRoot->addChild(sigTemp);
}
sigTemp->addChild(sigItem);
if (sigTemp)
sigTemp->addChild(sigItem);
}
}
}