Commit Graph
105 Commits
Author SHA1 Message Date
Collin Kidder 43979a6d58 Many fixes to the IsoTP Viewer and UDS internal code. 2020-04-02 19:53:35 -04:00
Collin Kidder 27b5d156b7 Bug fixes for ISOTP and UDS interpretation. 2020-03-17 21:26:17 -04:00
Collin Kidder 367c072b45 Various fixes to issues caused by recent transition to QCanBusFrame 2020-02-18 21:31:18 -05:00
Collin Kidder 909710fcfa Add text boxes to Fuzzing window to make it easy to set the bytes
directly and to show feedback while fuzzing is running.
2020-02-15 21:25:32 -05:00
Collin Kidder e4a3854af4 Many little changes to get rid of compile-time warnings.
There now should be no warnings when compiling on LINUX. YMMV elsewhere.
2020-02-15 19:52:18 -05:00
Collin Kidder d550fa79a0 Changed a lot of pointer references to const (it's more correct and
fixes a weird problem), fixed a problem with JSON to DBC, a few other
fixes
2020-02-13 22:01:06 -05:00
Collin Kidder 8beb0e31a0 Converted more code to be easier to generalize to larger CAN payloads
for CAN-FD. Improved some code to be faster. Fixed up some compile
time warnings.
2019-12-15 15:02:06 -05:00
Collin Kidder ef24036d1c Finished switching over everything to the new can format (I hope). It
seems to function now but much more testing is needed.
2019-12-13 21:06:48 -05:00
Collin Kidder 0baffa300f A partial commit that changes CANFrame over to be based on
QCanBusFrame so that things are more compatible with other Qt based
CAN bus code. Not complete yet but getting there.
2019-12-11 21:17:33 -05:00
Mark Schulte 902a82c318 [graphing] Ignore RTR messages
RTR messages will be incorrectly graphed as "0", even though it's not
a real message.
2019-12-05 17:14:27 -08:00
Collin Kidder 4a591f9279 Fixes to ISO-TP decoding 2019-09-19 19:45:20 -04:00
Collin Kidder ca9b83ddc9 Switched from QtHelp to using straight HTML files for help.
This is because AppImage (for linux) is readonly and QtHelp requires
write access. But, HTML files shouldn't.
2019-08-18 18:52:15 -04:00
Collin Kidder b6a15a28cd More fixes for compiler warnings - cleaning up code and making assumptions more clear 2019-08-12 22:02:07 -04:00
mjuhanne 428b19c5c4 - Save DBC file configuration when changed, and restore it when restarting the application (no need for manual entry everytime app is launched)
- Add GMLAN 29bit filtering feature. In addition to J1939 matching, it is now possible to match DBC messages using only the Arbitration Id (bits 14-26 of CAN Address), since  Priority id (higher bits) and Sender Id (lowest 13 bits) are not relevant when interpreting the CAN message content. This allows to use the excellent GM Global A DBC files on https://github.com/commaai/opendbc. Just remember to select the "GMLAN" matching criteria on DBC File manager.
- Add "Filter labeling" feature. Using loaded DBC files, it matches the filter Ids with DBC messages and shows them in filter windows. Labeling works in the main window (no need to set "Frame interpret" on, since this is a separate feature), as well as in Flow view, Frame data analysis, Playback and Fuzzzing windows. This makes it so much easier to concentrate on those CAN messages that matter. To use this feature, select global "Label filters using messages from DBC files" on Main Configuration page, and then enable the feature on individual DBC files (on DBC file manager) as needed. This is needed if there's overlap in CAN addresses between DBC files, and because the filter labeler cannot tell apart anymore which Filter ID is associated to which bus, it might label them incorrectly. But usually it's ok to just enable the labeling with all the DBC files.
- In Frame data analysis window, in addition to J1939 decoding show also GMLAN (Priority bits, Arbitration Id, Sender Id) decoding.
- FilterUtility static class used for centralized ListWidgetItem creation and for other helper functions
- DBC handler: To allow setting bus numbers even before connection is configured, do not enforce "valid" bus numbers
2019-08-11 23:16:02 +03:00
Collin Kidder 0567d5ef14 More changes meant just to fix up compiler warnings. 2019-08-08 22:09:02 -04:00
Collin Kidder 947f24f267 More fixes for compile warnings 2019-08-08 21:49:03 -04:00
Collin Kidder e7e65b7216 Fixed up a bunch of compiler warnings.
There should be no functional difference, just less noise when compiling
2019-08-08 21:15:51 -04:00
Collin Kidder 1fdd67777c Add more customization support to CANDataGrid. Used that new functionality in Flow View
to allow for bitfield triggers. Click a cell to trigger on it.
Now playback will stop if that cell changes state while playing back.
2019-08-01 21:57:03 -04:00
Collin Kidder 34298c0e6e Changed UDS scanner output to show the reply ID as well.
Now the root nodes are the sending ID we used, the next level shows the ID(s) that replied. Then each reply ID has under it all the services attempted and results.
2019-07-25 21:26:18 -04:00
Collin Kidder 8a23c32210 Tweaking of the new time histogram.
Now Y axis is logarithmic to make it easier to see the top and bottom of the ranges. Also,
the X axis is now labeled in milliseconds instead of by the 20 divisions.
2019-07-17 21:06:03 -04:00
Collin Kidder 7e212044bf Fix a divide by zero bug in frame info window. 2019-07-17 19:25:22 -04:00
Eisenmann 5d9a659eeb Add additional timing information and a histogram of intervals 2019-07-13 19:05:49 +02:00
Eisenmann ce4d92090a Avoid integer overflows when analysing large datasets 2019-07-13 18:07:28 +02:00
Collin Kidder d4a735a710 Allow many places to load and save the last directory used for that functionality so it can easily be used again.
All frame file I/O uses the same directory load/save location but DBC files store separately as do filter files, graphing definitions, and stored text files from the various reverse engineering windows.
2019-06-17 20:58:56 -04:00
Collin Kidder d75edabbfe Change abs to fabs so it will properly compile on Raspberry Pi 2019-06-11 20:58:54 -04:00
Collin Kidder 2552debd6d Sort messages and signals alphabetically to make it easier to find them. Also fixed a bug that would not allow signals to be found if not in the first loaded DBC file. 2019-05-28 21:47:04 -04:00
Collin Kidder 377b42c8e7 Fix some bugs related to graphing and loading graph definitions 2019-05-27 10:08:31 -04:00
Collin Kidder 539fecc16b Fix reported location when double clicking a graph. Now reported X,Y
location matches where the circle indicator is actually placed.
2019-05-06 21:49:10 -04:00
Collin Kidder c6cba08f2e Add colormapped background to temporal view. Makes it even easier to
see where traffic changes are.
2019-05-05 16:12:47 -04:00
Collin Kidder 164d5adadb Added a new window - Temporal Graph which shows all frame IDs and the
time stamp when they came in. Shows the temporal relationship between
all frames.
2019-05-05 11:52:32 -04:00
Collin Kidder 74f234a9f7 Tweaks to the associated signal tracking. Now there is a label that
tells you whether the parameters match the currently selected signal
or not.
2019-04-14 18:28:12 -04:00
Collin Kidder b8c83bbfd7 Fix parent for new graph window, fix empty graphs are impossible to
selectively remove or edit, add associated signal to graphs so they
bring up the proper signal in the list on the right in the editing
window.
2019-04-14 17:01:30 -04:00
Collin Kidder ba94db77bf Update version number, small fix to graphing window 2019-03-19 20:43:36 -04:00
Collin Kidder 734ed8cd5b Some formatting changes in comparator window, plus status update
changes.
2019-03-18 20:40:05 -04:00
Collin Kidder 1d218774dc Various changes to the file comparator window to make it a lot easier
to undestand.
2019-03-14 19:28:05 -04:00
Collin Kidder 75c2693a97 Additional updates to make coloring better for dark themes 2019-02-26 22:20:45 -05:00
Collin Kidder 5d427e8db4 Fixes to the sniffer visuals to allow them to adapt to dark themes in
the OS.
2019-02-26 22:02:33 -05:00
Collin Kidder e6ea250113 Tweaked the graph a bit in Flowview to make the X axis labels more
sensible.
2019-02-26 20:46:28 -05:00
Collin Kidder 1177e81bec Fix for crash in Flow View when a frame doesn't have 8 data bytes 2019-02-24 16:57:18 -05:00
Collin Kidder b54777d1aa Completion of adding a new mode to sniffer window (View Bits). Also
now it loads and saves the window position, size, and column sizes for
the sniffer window.
2019-02-20 21:14:25 -05:00
Collin Kidder f6269dd5f4 Make timestamp formatting use QVariant for better sorting by timestamp. 2019-02-17 14:43:13 -05:00
Collin Kidder 151217bc3f Merge branch 'master' of github.com:collin80/SavvyCAN into WIP 2019-02-13 21:00:19 -05:00
Collin Kidder 3f1e38b85b Slight change to column sizes in sniffer window. 2019-02-13 20:59:59 -05:00
MartinX 52f04791dd add setWindowFlags(Qt::Window) to improve window management
* improves window handling a lot
	(on Linux GNOME 3 at least: quickly resizing windows left/right, not forced in foreground anymore etc.)
	setWindowFlags() inserted in all *window.cpp files except mainwindow
    * some whitespace at EOL trimmed
2019-02-13 20:08:41 +01:00
Collin Kidder a138968e85 Additional work on new sniffer bitfield view. 2018-12-30 20:10:12 -05:00
Collin Kidder 576a6c87c5 Add preliminary version of a new data visualization idea in the
sniffer window.
2018-12-27 23:31:26 -05:00
Collin Kidder 29dec2dc65 Restructured the Frame Info window and added a graph of all the bytes
in the selected frame (color coded the same as the flowview)
2018-12-12 20:53:11 -05:00
Collin Kidder 66ad108f82 Add mute mode, fix bugs. Sniffer window seems to work well now. 2018-10-23 21:04:59 -04:00
Collin Kidder fbc71103af Fix for a variety of small issues with sniffer window. 2018-10-23 20:42:05 -04:00
Collin Kidder dd1c6b8a6e Updated Sniffer help, added a lot of functionality to Sniffer Window
Sniffer can now
keep all ids without expiring
Fade out bytes that aren't changing
2018-10-22 22:29:21 -04:00