Commit Graph
79 Commits
Author SHA1 Message Date
Refuhr e403282e87 fix: indentation of dbc files to be a single tab character
- bump version
2026-08-03 19:45:29 +02:00
Refuhr 68cf5098fb feat: sort multiplexed values by multiplex value ascending 2026-06-19 13:44:22 +02:00
Leopixelo 966c407638 fix sorting of multiplexed signals 2026-06-16 20:10:23 +02:00
Leopixelo 312165150f fix rebased version for QT5 compatibility + dbc handler fixes 2026-06-08 20:09:33 +02:00
Leopixelo 2682e7c84d sort signals in main window can frames view by start bit instead of name 2026-06-08 15:10:47 +02:00
Michele Tesser b4de4dfdf0 VAL_TABLE_ support 2026-04-13 18:49:18 +02:00
Jason Gill 7d5faae09f Properly output SIG_VALTYPE_ for float/double entries in DBC files 2026-03-20 10:34:34 -04:00
Collin Kidder 56fc509388 Merge pull request #960 from Initdd/fix/save-boolean-values
fix: Add support for boolean attribute values in DBC file saving
2025-07-28 21:15:16 -04:00
Initdd a15359ba76 fix: Add support for boolean attribute values in DBC file saving 2025-07-19 12:47:09 +01:00
Alexey Esaulenko 118f36e005 DBC parser: cached attributes cannot be read after attributes.append(...) 2025-06-25 21:47:14 +04:00
Collin Kidder 0ac26c1621 Fix a variety of DBC related issues, update version number at last (with plans to release soon!) 2025-05-08 20:41:37 -04:00
Collin Kidder 6f69f65444 Merge branch 'master' into support_multiple_signal_multiplex_values 2025-05-05 20:53:25 -04:00
Superwofy 6fb5299c6c Fix dbc handling of comments and attributes 2024-10-25 21:51:32 +01:00
Guinea Wheek 33c8b24b7c add support for SIG_VALTYPE_ 2024-05-02 13:34:18 -07:00
Miklos Marton 1dce603325 [DBC]Add support for multiple signal multiplexor values 2024-01-18 16:42:38 +01:00
Andy Huska f39b61f4e8 Fixed filterLabeling not loading from settings correctly 2023-05-22 16:33:44 -05:00
Andy Huska ab476c746e Added fully qualified dbc, node, and msg searching
...to graphing window and signal viewer so complex systems with message
name duplication (eg "Status") works well.  DBCHandler class has a new
function to find a msg by fully qualified node name...Utility class defines
the qualified name seperator, right now it is :: and is used thusly
filenameNoExtension::nodeName for display in the node dropdown (because
nodes can be common between dbc files).  To get the message from the
system you use the findMessage function in dbchandler and pass the
msgName and the fully qualified node name.  This is about as unique as we
can get, second only to message ID.

Added node comboBox to graph signal editor for easier data filtering
(took the same implementation that was in signal viewer, and tuned up
both of them)
2023-05-17 17:23:27 -05:00
Andy Huska 0f9a17123d Merge branch 'master' of github.com:qurrent-llc/SavvyCAN 2023-05-11 16:51:42 -05:00
Andy Huska a66e63ced9 Fixed some DBC file format errors
frame ID for extended IDs was not having its upper bit set
BA_DEF_DEF_ "filterlabeling" is INT type but was getting bool written
(e.g. 'false' instead of 0)
2023-05-11 16:45:41 -05:00
Collin Kidder 780e2fb1a2 Several changes suggested in draft pull requests from llange. Fix some
ambiguous places, fix warnings, fix errors when trying to compile with
QT6
2023-04-11 21:15:34 -04:00
Warrick d431c67aa3 Comments should come before attributes 2023-02-10 18:44:40 +13:00
Collin Kidder 8f9503ff0b Fixes for DBC saving, especially when saving extended frames. Saved
DBC files should load in Vector tools now.
2023-01-10 22:14:56 -05:00
Collin Kidder fa57b3ec55 Added undo functionality to signal editor. CTRL-Z undoes what you just
did but undo buffer currently is deleted when signal window is closed
so undoing is limited currently.

Seemingly fixed issue where it would
constantly think you edited the open DBC file when you didn't.
2022-12-29 21:25:11 -05:00
Collin Kidder 8ff3459c75 Fixed several DBC related bugs, expanded support for FD frames in the
DBC editor windows. Should more or less function now even for FD frames.
2022-12-07 21:51:44 -05:00
Collin Kidder edc210c336 Only code clean up to remove many warnings. There should be no changes
to program operation.
2022-12-05 19:33:47 -05:00
Andy Huska 18a9007750 Merge branch 'collin80:master' into fix_dbc_creation 2022-10-05 14:51:01 -07:00
bigoulours b8039f9b16 Priorizing exact match over J1939 and GMLAN
Hi Collin,
I had a case where two ECUs were sending the same PGN (with different contents though), leading to SavvyCAN picking the first found PGN-Match.
Hence my proposal: go over the list until an exact match is found, otherwise returning the best match (same PGN).
2022-09-28 15:42:19 +02:00
Andy Huska 27b58552df rebase working but definitely needs clean up for all the whatifs 2022-09-21 18:04:11 -05:00
Andy Huska 0ee9eacbb3 realized that the value list was already supported so reverted
my custom code.  The issue that made me go down this path
is related to the little endian checkbox mysteriously and
inconsistently unchecking and therefore interpreting enum values
wrong...would really like to find this.
2022-09-20 17:08:20 -05:00
Andy Huska 6accf2e9e7 Fixed bug in extended addressing check
where ID was being AND'ed with 80000000 decimal instead of hex
2022-09-20 16:48:11 -05:00
Andy Huska e6058ead34 Progress!
Masked error caused by saving dbc while editor is open that causes
msg IDs to go crazy by making editor modal, but that affects all
other windows, so might be a better fix.

Added new value type of VALUE_STRING, probably better named
ENUMERATED_STRING, and it uses the table in the editor to define
the enum.

Fixed a bug in the signal viewer load when a signal is not matched
(I found it by renaming a signal and then loading)
2022-09-20 16:23:18 -05:00
Andy Huska 13c920f971 Fixed regression where non-commented node would not delete
Fixed odd crash due to dbcNode being null on refresh
2022-09-20 07:46:30 -05:00
Andy Huska 7e4ebf2c74 Fixed nonfunctional node delete. Was due to trying to find node by name but
passing in the name and comment concatenated together.  Made a new function to
find by name+comment since extracting only name from the text in the column would
require too much guessing.
2022-09-15 18:59:24 -05:00
Andy Huska b6b73d0e11 Fixed crash when deleting a message that isn't at the bottom of the node 2022-09-15 18:39:56 -05:00
Collin Kidder bba4fccac6 Vast change to CAN data grid to show signal names. Many graphical
tweaks, some bug fixes.
2021-08-24 22:28:32 -04:00
Collin Kidder d78cb9878e Fix for another DBC related crash 2021-05-23 11:19:59 -04:00
Collin Kidder a1923f132b Fixed crash with adding DBC signals, slight code change for clarity in
DBC code
2021-05-23 10:52:23 -04:00
Collin Kidder 45193c1fad Added signal comparison to the file comparison window. Very poor, slow
proof of concept inplementation - will be improved soon.
2021-05-04 22:36:09 -04:00
Collin Kidder 35c1ef5387 Added ability to create multiple graphing windows that act separately.
Added ability to right check on signals in main view and graph them
directly.
2021-05-02 12:48:47 -04:00
Collin Kidder e64e84d6fa Bug fixes for extended IDs in DBC files, fix one off error in a few
places (Corrects fuzzing window ID range), re-enabled overwrite mode
showing all signals in a message
2021-04-28 21:41:33 -04:00
Collin Kidder af0194c5a5 Fixes to make extended multiplexing code work properly, implementation
of nested multiplexing in main screen for interpretation.

Overall, it's ugly but mostly functional at this point.
2021-02-25 21:24:21 -05:00
Collin Kidder bcfaffbe5d Switched code around to better support high/low range for multiplexed
signals
2021-02-23 22:14:43 -05:00
Collin Kidder e00aa1150a First pass implementing support for extended multiplexing.
This causes significant changes to the DBC interface. Things are
probably a bit broken right now. Committing to get it on record
before further large changes are done.
2021-02-23 21:22:56 -05:00
Collin Kidder a8cde9fc5f Fixed several seg faults and other errors in DBC code 2021-02-17 21:19:30 -05:00
Collin Kidder 3d4cf98e3d Minor fixes to DBC code 2020-11-18 20:31:39 -05:00
Collin Kidder a5b7410629 Add tracking of DBC editing in order to warn when exiting without saving, add sorting to DBC routines, add a new screen that allows one to compare two DBC files for changes/differences. 2020-07-29 20:45:36 -04:00
Collin Kidder 4cfb4b903a Added ability to delete nodes, messages, signals within tree. 2020-07-26 14:49:08 -04:00
Collin Kidder 717228a091 Added searching to DBC window to make it easier to find messages. Replaced deprecated random number calls with new method. 2020-07-15 18:23:18 -04:00
Collin Kidder ccab975a70 Fixes for loading tesla json files (if you somehow get some) 2020-04-02 19:55:04 -04:00
Collin Kidder e4a3854af4 Many little changes to get rid of compile-time warnings.
There now should be no warnings when compiling on LINUX. YMMV elsewhere.
2020-02-15 19:52:18 -05:00