t.mettler/giesCANne
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,280 Commits 1 Branch 0 Tags
8f9503ff0bdf152e2f897da39a2a4be1fad3a9ac
Commit Graph
112 Commits
Author SHA1 Message Date
Collin Kidder 8f9503ff0b Fixes for DBC saving, especially when saving extended frames. Saved 
DBC files should load in Vector tools now.
 2023-01-10 22:14:56 -05:00
Collin Kidder fa57b3ec55 Added undo functionality to signal editor. CTRL-Z undoes what you just 
did but undo buffer currently is deleted when signal window is closed
so undoing is limited currently.

Seemingly fixed issue where it would
constantly think you edited the open DBC file when you didn't.
 2022-12-29 21:25:11 -05:00
Collin Kidder 28256c517f Now right clicking a different signal within DBC Sig Editor will switch editing to 
that signal.
 2022-12-29 20:16:56 -05:00
Collin Kidder 9ea3c4746c Fix bitview in Signal Editor on MacOS 
MacOS didn't scale the bitfield widget quite the way it was supposed to. The layout has been redesigned to prevent this issue.
 2022-12-25 18:16:49 -05:00
Collin Kidder 7a6cace651 Switched to using set colors for signal view instead of random 
generation.
 2022-12-13 21:19:25 -05:00
Collin Kidder 4d18c393a9 The dbc signal editor window now refreshes to update the bitfield as 
editing takes place. Fixed a bug that caused duplicates of nodes to
appear in the parent node combobox
 2022-12-13 20:30:31 -05:00
Collin Kidder 1ef3f10d13 Change MSG to MESG because the Windows build failed. Apparently MSG 
already has a definition under Windows
 2022-12-11 18:19:03 -05:00
Collin Kidder ddf26bb9b8 Fixed tab order in signal editor, fixed bugs in copying a signal when 
adding a new signal, code clean up
 2022-12-08 21:55:19 -05:00
Collin Kidder 8ff3459c75 Fixed several DBC related bugs, expanded support for FD frames in the 
DBC editor windows. Should more or less function now even for FD frames.
 2022-12-07 21:51:44 -05:00
Collin Kidder edc210c336 Only code clean up to remove many warnings. There should be no changes 
to program operation.
 2022-12-05 19:33:47 -05:00
Andy Huska 04f4af1bf9 One lingering thing removed before PR 2022-10-09 10:57:25 -05:00
Andy Huska e86cfb277a Cleaned up all the UI elements and error checking for rebase and duplicate 2022-10-09 10:45:30 -05:00
Andy Huska 18a9007750 Merge branch 'collin80:master' into fix_dbc_creation 2022-10-05 14:51:01 -07:00
bigoulours b8039f9b16 Priorizing exact match over J1939 and GMLAN 
Hi Collin,
I had a case where two ECUs were sending the same PGN (with different contents though), leading to SavvyCAN picking the first found PGN-Match.
Hence my proposal: go over the list until an exact match is found, otherwise returning the best match (same PGN).
 2022-09-28 15:42:19 +02:00
Andy Huska 47d63c6296 duplicate works! multiplexed signals are not copied at this time 
need to learn more about them first

need to do clean up and corner case handling
 2022-09-22 18:04:27 -05:00
Andy Huska 27b58552df rebase working but definitely needs clean up for all the whatifs 2022-09-21 18:04:11 -05:00
Andy Huska 74366d1c6b context menu in place for node rebase/duplicate 
need to add menu for rebase options and code for both actions
 2022-09-20 17:49:04 -05:00
Andy Huska 0ee9eacbb3 realized that the value list was already supported so reverted 
my custom code.  The issue that made me go down this path
is related to the little endian checkbox mysteriously and
inconsistently unchecking and therefore interpreting enum values
wrong...would really like to find this.
 2022-09-20 17:08:20 -05:00
Andy Huska d9e371c494 The last commit of the ext ID fix removed need for modal editor 2022-09-20 16:50:04 -05:00
Andy Huska 6accf2e9e7 Fixed bug in extended addressing check 
where ID was being AND'ed with 80000000 decimal instead of hex
 2022-09-20 16:48:11 -05:00
Andy Huska e6058ead34 Progress! 
Masked error caused by saving dbc while editor is open that causes
msg IDs to go crazy by making editor modal, but that affects all
other windows, so might be a better fix.

Added new value type of VALUE_STRING, probably better named
ENUMERATED_STRING, and it uses the table in the editor to define
the enum.

Fixed a bug in the signal viewer load when a signal is not matched
(I found it by renaming a signal and then loading)
 2022-09-20 16:23:18 -05:00
Andy Huska 13c920f971 Fixed regression where non-commented node would not delete 
Fixed odd crash due to dbcNode being null on refresh
 2022-09-20 07:46:30 -05:00
Andy Huska 7e4ebf2c74 Fixed nonfunctional node delete. Was due to trying to find node by name but 
passing in the name and comment concatenated together.  Made a new function to
find by name+comment since extracting only name from the text in the column would
require too much guessing.
 2022-09-15 18:59:24 -05:00
Andy Huska b6b73d0e11 Fixed crash when deleting a message that isn't at the bottom of the node 2022-09-15 18:39:56 -05:00
Collin Kidder 37b9c821e5 Fix crash when deleting nodes in DBC editor 2021-09-19 18:55:25 -04:00
Collin Kidder 935032477d Modified CANDataGrid component to have two modes for better graphics, 
updated version number and presentation on main window
 2021-09-06 20:34:11 -04:00
Collin Kidder bba4fccac6 Vast change to CAN data grid to show signal names. Many graphical 
tweaks, some bug fixes.
 2021-08-24 22:28:32 -04:00
Collin Kidder d8f2c2d0e3 Implementation of colored signals in the can data grid. Not entirely 
perfect yet but it's something.
 2021-08-19 21:17:40 -04:00
Collin Kidder f53ad8a65a Fixed help system. 
Also switched from Sphinx generated HTML to GitHub markup help files.

This improves compatibility and will allow the help files to more easily be viewed on github as well.
 2021-05-30 23:40:47 -04:00
Collin Kidder d78cb9878e Fix for another DBC related crash 2021-05-23 11:19:59 -04:00
Collin Kidder a1923f132b Fixed crash with adding DBC signals, slight code change for clarity in 
DBC code
 2021-05-23 10:52:23 -04:00
Collin Kidder 45193c1fad Added signal comparison to the file comparison window. Very poor, slow 
proof of concept inplementation - will be improved soon.
 2021-05-04 22:36:09 -04:00
Collin Kidder 0d34958c63 Fixes to make graphing of multiplexed signals work properly 2021-05-02 20:58:23 -04:00
Collin Kidder 35c1ef5387 Added ability to create multiple graphing windows that act separately. 
Added ability to right check on signals in main view and graph them
directly.
 2021-05-02 12:48:47 -04:00
Collin Kidder 1844695a78 Added DBC signal value table strings to graphs of signals with value 
tables, incremented version number.
 2021-05-01 09:39:02 -04:00
Collin Kidder e64e84d6fa Bug fixes for extended IDs in DBC files, fix one off error in a few 
places (Corrects fuzzing window ID range), re-enabled overwrite mode
showing all signals in a message
 2021-04-28 21:41:33 -04:00
Collin Kidder af0194c5a5 Fixes to make extended multiplexing code work properly, implementation 
of nested multiplexing in main screen for interpretation.

Overall, it's ugly but mostly functional at this point.
 2021-02-25 21:24:21 -05:00
Collin Kidder bcfaffbe5d Switched code around to better support high/low range for multiplexed 
signals
 2021-02-23 22:14:43 -05:00
Collin Kidder e00aa1150a First pass implementing support for extended multiplexing. 
This causes significant changes to the DBC interface. Things are
probably a bit broken right now. Committing to get it on record
before further large changes are done.
 2021-02-23 21:22:56 -05:00
Collin Kidder a8cde9fc5f Fixed several seg faults and other errors in DBC code 2021-02-17 21:19:30 -05:00
Collin Kidder 9c14920ffc Merge branch 'WIP' of github.com:collin80/SavvyCAN into WIP 2021-02-01 22:14:24 -05:00
Collin Kidder 3d4cf98e3d Minor fixes to DBC code 2020-11-18 20:31:39 -05:00
Collin Kidder b345495178 Fix compilation on Windows, fix glitch that could cause windows to appear off the actual screen with no way to get them back. 2020-11-15 01:30:13 -08:00
Collin Kidder 1c7caa3884 Fix some errors created during last merge. 2020-09-30 21:55:39 -04:00
Collin Kidder 9d545d44d1 Merge pull request #245 from collin80/WIP 
Wip
 2020-09-30 18:42:57 -07:00
Sam Nobs b556016bba Use integer formatting where possible when interpreting signal. 
Numbers are formatted as floating point numbers, which looks
a bit crap for things like e.g. serial numbers (we don't need
mantissa and exponent). This change checks the scaling factor,
and if it is integer representable, the resulting number is
formatted as an integer number as that's most likely what's
intended, particularly if the factor is 1.
 2020-09-18 15:39:08 +12:00
Collin Kidder fbfc1f8c64 Now the DBC Message editor can change the parent node of a message and you can create new nodes simply by typing something new into the sender field. 2020-07-30 21:44:36 -04:00
Collin Kidder a5b7410629 Add tracking of DBC editing in order to warn when exiting without saving, add sorting to DBC routines, add a new screen that allows one to compare two DBC files for changes/differences. 2020-07-29 20:45:36 -04:00
Collin Kidder 4cfb4b903a Added ability to delete nodes, messages, signals within tree. 2020-07-26 14:49:08 -04:00
Collin Kidder 1a1ccb5fec Initial implementation of adding nodes, messages, signals with new tree style. 2020-07-23 21:52:43 -04:00