Andy Huska
5ffe161210
more clean up
2022-09-23 15:30:58 -05:00
Andy Huska
f38e0b0bfa
Took out unnecessary exception recover code
...
Cuz app is going to crash anyway, no need to make a mess
2022-09-23 15:28:41 -05:00
Collin Kidder
a3bd67ea99
Merge pull request #499 from qurrent-llc/fix_addframebadalloc
...
Fix frames and filteredFrames from growing until out of memory
2022-09-22 18:12:54 -05:00
Collin Kidder
5a4f211ca0
Merge pull request #498 from qurrent-llc/fix_dbc_delete
...
Fixed regression where non-commented dbc editor node would not delete
2022-09-22 18:11:47 -05:00
Andy Huska
47d63c6296
duplicate works! multiplexed signals are not copied at this time
...
need to learn more about them first
need to do clean up and corner case handling
2022-09-22 18:04:27 -05:00
Andy Huska
27b58552df
rebase working but definitely needs clean up for all the whatifs
2022-09-21 18:04:11 -05:00
Andy Huska
74366d1c6b
context menu in place for node rebase/duplicate
...
need to add menu for rebase options and code for both actions
2022-09-20 17:49:04 -05:00
Andy Huska
0ee9eacbb3
realized that the value list was already supported so reverted
...
my custom code. The issue that made me go down this path
is related to the little endian checkbox mysteriously and
inconsistently unchecking and therefore interpreting enum values
wrong...would really like to find this.
2022-09-20 17:08:20 -05:00
Andy Huska
d9e371c494
The last commit of the ext ID fix removed need for modal editor
2022-09-20 16:50:04 -05:00
Andy Huska
6accf2e9e7
Fixed bug in extended addressing check
...
where ID was being AND'ed with 80000000 decimal instead of hex
2022-09-20 16:48:11 -05:00
Andy Huska
da7a721494
Changed default signalviewer message matching to be by ID
2022-09-20 16:27:53 -05:00
Andy Huska
e6058ead34
Progress!
...
Masked error caused by saving dbc while editor is open that causes
msg IDs to go crazy by making editor modal, but that affects all
other windows, so might be a better fix.
Added new value type of VALUE_STRING, probably better named
ENUMERATED_STRING, and it uses the table in the editor to define
the enum.
Fixed a bug in the signal viewer load when a signal is not matched
(I found it by renaming a signal and then loading)
2022-09-20 16:23:18 -05:00
Andy Huska
536122f3b5
Merge branch 'fix_dbc_delete'
2022-09-20 14:36:29 -05:00
Andy Huska
616718262e
Merge branch 'collin80:master' into add_nodenameinsignalviewer
2022-09-20 06:13:02 -07:00
Andy Huska
53882805e7
Merge branch 'collin80:master' into add_allowfilterstostayuponclear
2022-09-20 06:12:05 -07:00
Andy Huska
6be8e8e002
Merge branch 'collin80:master' into fix_addframebadalloc
2022-09-20 05:54:23 -07:00
Andy Huska
aea5e9f9c8
Merge branch 'fix_dbc_delete' of github.com:qurrent-llc/SavvyCAN into fix_dbc_delete
2022-09-20 07:51:45 -05:00
Andy Huska
13c920f971
Fixed regression where non-commented node would not delete
...
Fixed odd crash due to dbcNode being null on refresh
2022-09-20 07:46:30 -05:00
Andy Huska
42b020e48b
Merge pull request #1 from collin80/master
...
Pull in PRs from upstream fork
2022-09-19 17:39:41 -07:00
Collin Kidder
dd5dc9d638
Merge pull request #496 from qurrent-llc/fix_dbc_delete
...
Fix dbc delete node non-function and dbc delete message occasional crash
2022-09-19 18:48:09 -05:00
Collin Kidder
e2ad516bd2
Merge pull request #495 from qurrent-llc/fix_socketcand
...
Fix two socketcand issues: start up switch to raw mode, crash due to partial frame
2022-09-19 18:47:31 -05:00
Collin Kidder
f9934b11fe
Merge pull request #494 from qurrent-llc/fix_framesenderloadtrailing0x00
...
Fixed data string parsing bug where a trailing space is treated as a zero
2022-09-19 18:47:19 -05:00
Collin Kidder
c14c5aa241
Merge pull request #484 from Sheimy/patch-1
...
Solve restore network connection not working
2022-09-19 18:46:29 -05:00
Andy Huska
9e9195b34e
changed default data table font to be fixed-width for easier reading
2022-09-19 16:13:30 -05:00
Andy Huska
40dbf253af
Saving, loading, clearing, and appending signal lists working!!
2022-09-19 15:28:53 -05:00
Andy Huska
afede9573b
Merge branch 'fix_addframebadalloc'
2022-09-19 13:51:31 -05:00
Andy Huska
cb94cac205
Fixed issue where filteredFrames was having its capacity changed
...
when adjusting filters due to appending a QVector of frames which
appears to change the capacity to the number of items appended.
Also fixed bug where preallocsize was being locally defined and
therefore the global version wasn't being updated with unknown
effets.
2022-09-19 13:47:57 -05:00
Andy Huska
6fa84df7e0
Added ability to maintain bus and msg filters when clearing frames
2022-09-19 13:31:00 -05:00
Andy Huska
07d1610a63
Merge branch 'fix_addframebadalloc'
2022-09-19 13:11:22 -05:00
Andy Huska
d56b35ea91
Made max # of frames an option in preferences, restart to take effect
2022-09-19 13:10:33 -05:00
Andy Huska
fd657b9b9b
Merge branch 'fix_addframebadalloc'
2022-09-19 12:48:43 -05:00
Andy Huska
195c90c415
change the max amount of the reserved space for the frames and filteredFrames vectors
...
to be 99% of the capacity instead of 95%.
Reset initial capacity to be 10M frames for 64-bit machines now that testing is done.
Want to make the capacity adjustable by user, too.
2022-09-18 13:01:34 -05:00
Andy Huska
dfc7b095c8
Added node name as part of the signal name that gets copied into the data table
2022-09-17 13:54:59 -05:00
Andy Huska
e06112b14c
Merge branch 'fix_dbc_delete'
2022-09-17 13:33:13 -05:00
Andy Huska
b9899ee229
Merge branch 'fix_socketcand'
2022-09-17 13:33:00 -05:00
Andy Huska
008ac6b744
Merge branch 'fix_framesenderloadtrailing0x00'
2022-09-17 13:32:47 -05:00
Andy Huska
99640d7239
Fixed data string parsing bug where an empty string created by a trailing space would be interpreted as a 0 and then added as a data byte
...
This affected editing of the data in the table as well as loading data from a saved file
2022-09-17 13:16:02 -05:00
Andy Huska
6cf404701e
Bug was due to treating an empty token as a 0, so fixed the string parsing to ignore empty tokens
2022-09-17 13:04:39 -05:00
Andy Huska
57f506b4dd
Merge branch 'fix_socketcand' into fix_addframebadalloc
2022-09-17 12:53:57 -05:00
Andy Huska
60520b5939
Added handing of ok message from RAW mode switch coming in out of order with other messages...
...
For now I made it its own else statement so it can be detected
2022-09-17 12:52:03 -05:00
Andy Huska
47d07b8bf2
Fixed bug where switching to RAW mode would fail due to the "ok" response being received in the same message as the first data frame
...
Sometimes when opening socketcand 1 or more busses won't start right and there's a ton of debug data saying "received datagramm: ...."
It seems to happen because the switch to RAW mode is in progress and we receive the OK with a frame in the same datagramm and we don't parse the OK out of the string
but rather expect the whole string to just be OK. Offending code is in socketcand.cpp SocketCANd::procRXData line 386
Fixed by looking to see if the < ok > message was at index 0 of the incoming message...could also look for it elsewhere (as in index != -1), but not sure if necessary
2022-09-17 12:48:48 -05:00
Andy Huska
742956d46c
Working on finding a way to prevent bad_alloc crash, temp stuff in place like prealloc size, and frames list resize (prob need to keep list below size limit to prevent chaos...10M msgs or so mabe)
2022-09-17 12:33:15 -05:00
Andy Huska
7b966fe4a6
Fixed incorrect handling of partial frame tagged onto the end of a complete frame.
...
Not sure if my method drops the partial or just sends the buffer back to continue filling.
2022-09-16 15:38:54 -05:00
Andy Huska
7e4ebf2c74
Fixed nonfunctional node delete. Was due to trying to find node by name but
...
passing in the name and comment concatenated together. Made a new function to
find by name+comment since extracting only name from the text in the column would
require too much guessing.
2022-09-15 18:59:24 -05:00
Andy Huska
b6b73d0e11
Fixed crash when deleting a message that isn't at the bottom of the node
2022-09-15 18:39:56 -05:00
Ahmed Sheimy
1c87008970
Update canconfactory.cpp
...
restore network connection was not working because it was detected as serial by this modification it is working
2022-08-05 18:32:45 +04:00
Collin Kidder
2afd41b681
Full revert of SavvyCAN.desktop so continuous build will succeed.
...
Should soon fix it to work the way it had been though.
2022-06-21 21:46:29 -04:00
Collin Kidder
ed84e7e9f8
Fix to sniffer when viewing bits, output formatting change for ID
2022-06-21 21:12:22 -04:00
Collin Kidder
7dd5ee1216
Fixes to hopefully parse CANalyzer files more accurately.
2022-06-21 21:11:28 -04:00
Collin Kidder
0514b29fc9
Revert the changes to SavvyCAN.desktop because it broke the continous
...
build. Investigate the proper way forward.
2022-06-21 21:10:48 -04:00
Andy Huska