From 3d4db6e921bebf3abd36be20b2fc578b131be577 Mon Sep 17 00:00:00 2001 From: Collin Kidder Date: Sun, 8 Jan 2017 19:25:03 -0500 Subject: [PATCH] Fixed broken DBC string signal code, make signal size automatically update in signal editor --- dbc/dbc_classes.cpp | 2 +- dbc/dbcsignaleditor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dbc/dbc_classes.cpp b/dbc/dbc_classes.cpp index 03d4bc5..1927ab8 100644 --- a/dbc/dbc_classes.cpp +++ b/dbc/dbc_classes.cpp @@ -45,7 +45,7 @@ bool DBC_SIGNAL::processAsText(const CANFrame &frame, QString &outString) if (valType == STRING) { QString buildString; - int startByte = signalSize / 8; + int startByte = startBit / 8; int bytes = signalSize / 8; for (int x = 0; x < bytes; x++) buildString.append(frame.data[startByte + x]); outString = buildString; diff --git a/dbc/dbcsignaleditor.cpp b/dbc/dbcsignaleditor.cpp index 5e5c832..18efd7b 100644 --- a/dbc/dbcsignaleditor.cpp +++ b/dbc/dbcsignaleditor.cpp @@ -139,7 +139,7 @@ DBCSignalEditor::DBCSignalEditor(DBCHandler *handler, QWidget *parent) : if (currentSignal == NULL) return; currentSignal->unitName = ui->txtUnitName->text().simplified().replace(' ', '_'); }); - connect(ui->txtBitLength, &QLineEdit::editingFinished, + connect(ui->txtBitLength, &QLineEdit::textChanged, [=]() { if (currentSignal == NULL) return;