t.mettler/giesCANne
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SocketCANd: fix memory leak: string can be accessed after object destruction

Browse Source
This commit is contained in:
Alexey Esaulenko
2024-01-19 15:00:39 +04:00
parent 0885149492
commit 2082845d03
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connections/socketcand.cpp
+2 -4
View File
@@ -219,8 +219,8 @@ void SocketCANd::connectDevice()
void SocketCANd::deviceConnected(int busNum) void SocketCANd::deviceConnected(int busNum)
{ {
sendDebug("Opening CAN on Kayak Device!"); sendDebug("Opening CAN on Kayak Device!");
const char* openCanCmd = ("< open " + hostCanIDs[busNum] + " >").toStdString().c_str(); QString openCanCmd("< open " % hostCanIDs[busNum] % " >");
sendStringToTCP(openCanCmd, busNum); sendStringToTCP(openCanCmd.toUtf8().data(), busNum);
QCoreApplication::processEvents(); QCoreApplication::processEvents();
} }
@@ -383,8 +383,6 @@ void SocketCANd::procRXData(QString data, int busNum)
mTimer.stop(); mTimer.stop();
mTimer.start(); mTimer.start();
} }
QByteArray output;
switch (rx_state.at(busNum)) switch (rx_state.at(busNum))
{ {
case IDLE: case IDLE: