t.mettler/giesCANne
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

realized that the value list was already supported so reverted

Browse Source 
my custom code.  The issue that made me go down this path
is related to the little endian checkbox mysteriously and
inconsistently unchecking and therefore interpreting enum values
wrong...would really like to find this.
This commit is contained in:
Andy Huska
2022-09-20 17:08:20 -05:00
parent d9e371c494
commit 0ee9eacbb3
4 changed files with 3 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dbc/dbc_classes.cpp
+2 -13
View File
@@ -137,17 +137,6 @@ bool DBC_SIGNAL::processAsText(const CANFrame &frame, QString &outString, bool o
cachedValue = outString;
return true;
}
else if(valType == VALUE_STRING)
{
result = Utility::processIntegerSignal(frame.payload(), startBit, signalSize, intelByteOrder, isSigned);
if(!getValueString(result, outString))
{
outString = "Signal string value is undefined";
}
return true;
}
if (valType == SIGNED_INT) isSigned = true;
if (valType == SIGNED_INT || valType == UNSIGNED_INT)
@@ -240,7 +229,7 @@ bool DBC_SIGNAL::processAsInt(const CANFrame &frame, int32_t &outValue)
int32_t result = 0;
bool isSigned = false;
if (valType == STRING || valType == VALUE_STRING || valType == SP_FLOAT || valType == DP_FLOAT)
if (valType == STRING || valType == SP_FLOAT || valType == DP_FLOAT)
{
return false;
}
@@ -273,7 +262,7 @@ bool DBC_SIGNAL::processAsDouble(const CANFrame &frame, double &outValue)
bool isSigned = false;
double endResult;
if (valType == STRING || valType == VALUE_STRING)
if (valType == STRING)
{
return false;
}